Re: [libvirt] [PATCH 12/13] Protection against doing bad stuff to the root group
On Tue, Jul 23, 2013 at 03:58:30PM -0600, Eric Blake wrote:
On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> Add protection such that the virCgroupRemove and
> virCgroupKill* do not do anything to the root cgroup.
>
> Killing all PIDs in the root cgroup does not end well.
I take it you tried this, on accident :)
Yes, due to a bug elsewhere in the code I ended up with an
LXC container in the / cgroup. When killing the container
libvirt recursively kills all processes in the container's
cgroup. When the cgroup is / this is all processes on the
host until it kills itself :-) I now have a 30 mile journey
to the colo to reboot this machine since I have no remote
power control on it :-)
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|