[PATCH 07/10] networkGetDHCPLeases: Use VIR_APPEND_ELEMENT() instead of VIR_INSERT_ELEMENT()

This function is misusing VIR_INSERT_ELEMENT() to behave like VIR_APPEND_ELEMENT(). Use the latter to make it explicit what we are trying to achieve. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 191e429ea2..43102a02c1 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4179,7 +4179,7 @@ networkGetDHCPLeases(virNetworkPtr net, lease->clientid = g_strdup(virJSONValueObjectGetString(lease_tmp, "client-id")); lease->hostname = g_strdup(virJSONValueObjectGetString(lease_tmp, "hostname")); - if (VIR_INSERT_ELEMENT(leases_ret, nleases, nleases, lease) < 0) + if (VIR_APPEND_ELEMENT(leases_ret, nleases, lease) < 0) goto error; } else { -- 2.26.2