Re: [libvirt PATCH] conf: Use unsigned long long for timer frequency
On Wed, Nov 11, 2020 at 22:47:34 +0100, Martin Kletzander wrote:
On Wed, Nov 11, 2020 at 06:00:52PM +0100, Jiri Denemark wrote:
>Although the code in qemuProcessStartValidateTSC works as if the
>timer frequency was already unsigned long long (by using an appropriate
>temporary variable), the virDomainTimerDef structure actually defines
>frequency as unsigned long, which is not guaranteed to be 64b.
>
>Fixes support for frequencies higher than 2^32 - 1 on 32b systems.
>
>Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
Yeah, sure, why not. I mean:
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
>---
> src/conf/domain_conf.c | 6 +++---
> src/conf/domain_conf.h | 2 +-
> src/qemu/qemu_command.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
Tests when?
Tests were added in "schema: Add support for high TSC frequency" which
caused our CI to fail on i686. This is just a fallout of the trivial
schema change accompanied with proper tests :-)
Jirka