Re: [libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

Everything can be disabled by not using the parent element. There's no need to store this explicitly. Additionally it does not add any value since any configuration is dropped if enabled='no' is configured. Drop the attribute and adjust the code accordingly.t Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- docs/formatdomain.html.in | 21 ++-- docs/schemas/storagecommon.rng | 3 - src/util/virstoragefile.c | 117 +++++++++------------ src/util/virstoragefile.h | 1 - .../disk-virtio-scsi-reservations.xml | 4 +- 5 files changed, 59 insertions(+), 87 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 80172c18d0..d69a669259 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2583,7 +2583,7 @@ &lt;disk type='block' device='lun'&gt; &lt;driver name='qemu' type='raw'/&gt; &lt;source dev='/dev/sda'&gt; - &lt;reservations enabled='yes' managed='no'&gt; + &lt;reservations managed='no'&gt; &lt;source type='unix' path='/path/to/qemu-pr-helper' mode='client'/&gt; &lt;/reservations&gt; &lt;target dev='sda' bus='scsi'/&gt; @@ -2952,17 +2952,16 @@ <dd><span class="since">Since libvirt 4.4.0</span>, the <code>reservations</code> can be a sub-element of the <code>source</code> element for storage sources (QEMU driver only). - If present (and enabled) it enables persistent reservations for SCSI + If present it enables persistent reservations for SCSI based disks. The element has one mandatory attribute - <code>enabled</code> with accepted values <code>yes</code> and - <code>no</code>. If the feature is enabled, then there's another - mandatory attribute <code>managed</code> (accepted values are the - same as for <code>enabled</code>) that enables or disables libvirt - spawning a helper process. When the PR is unmanaged, then hypervisor - acts as a client and path to server socket must be provided in child - element <code>source</code>, which currently accepts only the - following attributes: <code>type</code> with one value - <code>unix</code>, <code>path</code> with path the socket, and + <code>managed</code> with accepted values <code>yes</code> and + <code>no</code>. If <code>managed</code> is enabled libvirt prepares + and manages any resources needed for the feature. When the PR is

+ unmanaged, then hypervisor acts as a client and path to server

+ socket must be provided in child element <code>source</code>,

+ which currently accepts only the following attributes: + <code>type</code> with one value <code>unix</code>, + <code>path</code> with path the socket, and

finally <code>mode</code> which accepts one value <code>client</code> and specifies the role of hypervisor.

It's recommended to allow libvirt manage the persistent