Re: [libvirt] [PATCH 16/18] qemu: Support scsi controller model=virtio-{non-}transitional

On 01/23/2019 07:08 AM, Andrea Bolognani wrote: > On Tue, 2019-01-22 at 16:27 -0500, Cole Robinson wrote: >> On 01/22/2019 12:39 PM, Cole Robinson wrote: >>> On 01/21/2019 11:49 AM, Andrea Bolognani wrote: >>>> Completely agree with the rationale here; however, in order to >>>> really match the way other devices are handled, I think we should >>>> make it so you can use >>>> >>>> <controller type='scsi' model='virtio'/> >>>> >>>> as well, which of course would behave the same as the currently >>>> available version. What do you think? >>> >>> Yes I agree it would be nice to add that option. I suggest we make it a >>> separate issue from this series though incase it's a contentious idea, >>> v2 is already shaping up to be ~30 patches... > > I don't think that's going to be particularly controversial, and we > should really make sure we get all the user-facing bits in at the > same time IMHO, so I'd say go for it... If you're really unsure > about it you can add that model in a separate patch right after this > one, that way if someone happens not to like that we can drop it and > otherwise we can squash them together before pushing. > Alright will do