12:36 p.m.
v1: https://www.redhat.com/archives/libvir-list/2019-February/msg00187.html
Much of this was R-by'd for V1 with caveats for splitting things out, etc.
Still since there isn't an end of release rush ;-) - I figure reposting
everything before doing any sort of push would be more prudent and
conservative course of action!
I've added R-by's for many of the patches, but with all the requested
change - there were a few that we hadn't "closed on" from v1 that
didn't
get an R-by... The following is a "map" of the patches:
Patches 1-3 = Old Patch1 - All 3 R-by'd
Patch 4 = Old Patch2 - Has R-by
Patches 5-7 = Old Patch3 - All 3 R-by'd
Patches 8-9 = Old Patch4 - 8 needs an R-by, although 9 has it
Patch 10 = Old Patch5 - Has R-by
Patch 11 = Old Patch6 - Has R-by
Patch 12 = Old Patch7 - Needs R-by since I kept VIR_STEAL_PTR logic in
virStorageBackendLogicalFindPoolSourcesFunc
Patch 13 = Old Patch8 - Has R-by
Patches 14-15 = Old Patch9 - Didn't include R-by since I split out the noted
issue in virStorageBackendSCSINewLun
Patch 16 = Old Patch10 - Has R-by
Patches 17-18 = Old Patch11 - Both have R-by
Patches 19-21 = Old Patch12 - All 3 R-by'd
Patch 22 = Old Patch13 - Has R-by
Patch 23 = Old Patch14 - Has R-by
Patch 24 = NEW - "Fallout" from Old Patch4 review
Patch 25 = Old Patch15 - Took implicity R-by for VIR_STEAL_PTR extraction
Patches 26-32 = Old Patch15 - None have R-by. I split out the @def/@ret logic,
then created the VIR_AUTOPTR patch from there.
If the virstoragefile modifications are too much
no big deal. Perhaps they can be reworked or just
dropped. Everyone has their favorite way of doing
things I guess.
John Ferlan (32):
conf,util,qemu: Use VIR_STEAL_PTR for authdef processing
util: Rework virStorageAuthDefCopy
util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageAuthDef
conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolSource
storage: Use VIR_STEAL_PTR for gluster volume processing
conf: Rework virStorageVolDefParseXML
conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageVolDef
conf: Rework virStoragePoolDefParseXML
conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolDef
storage: Use VIR_AUTOPTR(virString)
storage: Use VIR_AUTOPTR(virCommand)
storage: Use VIR_AUTOFREE for storage backends
storage: Use VIR_AUTOFREE for storage driver
util: Fix virStorageBackendSCSINewLun error handling
storage: Use VIR_AUTOFREE for storage util
conf: Use VIR_AUTOFREE for storage_conf
util: Use VIR_STEAL_PTR in virstoragefile
util: Use VIR_AUTOFREE for virstoragefile
test: Cleanup testDomainRenameCallback
test: Remove unused @xml from testDomainSnapshotCreateXML
test: Use VIR_AUTOFREE for test driver
tests: Use VIR_AUTOFREE for various storage tests
storage: Use VIR_AUTOCLOSE
tests: Fix memory leak in testCompareXMLToArgvFiles
storage: Use VIR_STEAL_PTR in storageBackendProbeTarget
util: Rename variable in virStorageFileMetadataNew
util: Rename variable in virStorageSourceCopy
util: Rename variable in virStorageSourceNewFromBackingRelative
util: Rename variable in virStorageSourceNewFromBackingAbsolute
util: Rename variable in virStorageSourceNewFromBacking
tests: Rename variable in testStorageFileGetMetadata
util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource
src/conf/domain_conf.c | 35 +-
src/conf/storage_conf.c | 334 +++++------
src/conf/storage_conf.h | 4 +
src/conf/virstorageobj.c | 27 +-
src/esx/esx_storage_backend_vmfs.c | 6 +-
src/phyp/phyp_driver.c | 6 +-
src/qemu/qemu_domain.c | 3 +-
src/qemu/qemu_driver.c | 9 +-
src/qemu/qemu_migration.c | 3 +-
src/qemu/qemu_parse_command.c | 6 +-
src/storage/storage_backend.c | 9 +-
src/storage/storage_backend_disk.c | 147 ++---
src/storage/storage_backend_fs.c | 59 +-
src/storage/storage_backend_gluster.c | 45 +-
src/storage/storage_backend_iscsi.c | 76 +--
src/storage/storage_backend_iscsi_direct.c | 61 +-
src/storage/storage_backend_logical.c | 139 ++---
src/storage/storage_backend_mpath.c | 42 +-
src/storage/storage_backend_rbd.c | 44 +-
src/storage/storage_backend_scsi.c | 81 +--
src/storage/storage_backend_sheepdog.c | 107 ++--
src/storage/storage_backend_vstorage.c | 39 +-
src/storage/storage_backend_zfs.c | 77 +--
src/storage/storage_driver.c | 85 +--
src/storage/storage_file_fs.c | 15 +-
src/storage/storage_file_gluster.c | 16 +-
src/storage/storage_util.c | 553 +++++++-----------
src/test/test_driver.c | 208 +++----
src/util/virstoragefile.c | 620 +++++++++------------
src/util/virstoragefile.h | 3 +
src/vbox/vbox_storage.c | 3 +-
tests/qemublocktest.c | 6 +-
tests/storagebackendsheepdogtest.c | 59 +-
tests/storagepoolxml2argvtest.c | 29 +-
tests/storagepoolxml2xmltest.c | 36 +-
tests/storagevolxml2argvtest.c | 56 +-
tests/storagevolxml2xmltest.c | 44 +-
tests/virstoragetest.c | 111 ++--
tests/virstorageutiltest.c | 7 +-
39 files changed, 1181 insertions(+), 2029 deletions(-)
--
2.20.1