Re: [libvirt] [PATCH] conf: Always use VIR_ERR_XML_ERROR on enumFromString() failures

On Fri, Jan 10, 2014 at 06:13:21PM +0100, Christophe Fergeau wrote: > Currently, during XML parsing, when a call to a FromString() function to > get an enum value fails, the error which is reported is either > VIR_ERR_CONFIG_UNSUPPORTED, VIR_ERR_INTERNAL_ERROR or VIR_ERR_XML_ERROR. > > This commit makes such conversion failures consistently return > VIR_ERR_XML_ERROR Nice cleanup, but we should use CONFIG_UNSUPPORTED as that has pretty clearly defined semantics.