Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

Hello! > I don't think we should use enums at all in the protocol > specification. It should be unsigned int and the change should be > made separately. Is this hunk here because portable-rpcgen has > problems with enum being declared there? Yes, its parser fails. I have checked throughout the code, there are some other enums in .x files too, but when they are put in structs, they are specified without 'enum' keyword and everything is fine. For example, virnetprotocol.x: --- cut --- struct virNetMessageHeader { unsigned prog; /* Unique ID for the program */ unsigned vers; /* Program version number */ int proc; /* Unique ID for the procedure within the program */ virNetMessageType type; /* Type of message */ unsigned serial; /* Serial number of message. */ virNetMessageStatus status; }; --- cut --- Here virNetMessageType and virNetMessageStatus are enums. Actually i borrowed fix method from here.

Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia