Re: [Libvir] PATCH: Autodetect QEMU version
Hey,
Looks cool, just spotted ...
On Thu, 2007-02-22 at 18:32 +0000, Daniel P. Berrange wrote:
+ rewait:
+ if (waitpid(child, &got, 0) != child) {
+ if (errno == EINTR) {
+ goto rewait;
+ }
+ qemudLog(QEMUD_ERR, "Unexpected exit status from qemu %d pid %d",
got, child);
You want:
qemudLog(QEMUD_ERR, "Failed to wait on PID %lu : %s",
(unsigned long)child, strerror(errno));
(Also, should use pid_t for the child PID)
Cheers,
Mark.