Re: [libvirt] [PATCH 01/10] Provide a simple object for encoding/decoding RPC messages

This provides a new struct that contains a buffer for the RPC message header+payload, as well as a decoded copy of the message header. There is an API for applying a XDR encoding & decoding of the message headers and payloads. There are also APIs for maintaining a simple FIFO queue of message instances. Expected usage scenarios are: To send a message msg = virNetMessageNew() ...fill in msg->header fields.. virNetMessageEncodeHeader(msg) ...loook at msg->header fields to determine payload filter virNetMessageEncodePayload(msg, xdrfilter, data) ...send msg->bufferLength worth of data from buffer To receive a message msg = virNetMessageNew() ...read VIR_NET_MESSAGE_LEN_MAX of data into buffer virNetMessageDecodeLength(msg) ...read msg->bufferLength-msg->bufferOffset of data into buffer virNetMessageDecodeHeader(msg) ...look at msg->header fields to determine payload filter virNetMessageDecodePayload(msg, xdrfilter, data) ...run payload processor

+++ b/src/Makefile.am @@ -1202,6 +1202,7 @@ EXTRA_DIST += $(LIBVIRT_QEMU_SYMBOL_FILE) noinst_LTLIBRARIES += libvirt-net-rpc.la libvirt_net_rpc_la_SOURCES = \ + rpc/virnetmessage.h rpc/virnetmessage.c \ rpc/virnetprotocol.h rpc/virnetprotocol.c

libvirt_net_rpc_la_CFLAGS = \ $(AM_CFLAGS) diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c new file mode 100644 index 0000000..4c226d2 --- /dev/null +++ b/src/rpc/virnetmessage.c @@ -0,0 +1,365 @@ +/* + * virnetmessage.h: basic RPC message encoding/decoding + * + * Copyright (C) 2010 Red Hat, Inc.

+/* + * @msg: the outgoing message, whose header to encode + * + * Encodes the length word and header of the message, setting the

diff --git a/src/rpc/virnetmessage.h b/src/rpc/virnetmessage.h new file mode 100644 index 0000000..9a92c0b --- /dev/null +++ b/src/rpc/virnetmessage.h @@ -0,0 +1,70 @@ +/* + * virnetmessage.h: basic RPC message encoding/decoding + * + * Copyright (C) 2010 Red Hat, Inc.

+ +struct _virNetMessage { + char buffer[VIR_NET_MESSAGE_MAX + VIR_NET_MESSAGE_LEN_MAX];

+void virNetMessageFree(virNetMessagePtr msg);

+ +virNetMessagePtr virNetMessageQueueServe(virNetMessagePtr *queue);

+void virNetMessageQueuePush(virNetMessagePtr *queue, + virNetMessagePtr msg);

+ +int virNetMessageEncodeHeader(virNetMessagePtr msg);

+int virNetMessageDecodeLength(virNetMessagePtr msg);

+int virNetMessageDecodeHeader(virNetMessagePtr msg);

+ +int virNetMessageEncodePayload(virNetMessagePtr msg, + xdrproc_t filter, + void *data);

+int virNetMessageDecodePayload(virNetMessagePtr msg, + xdrproc_t filter, + void *data);

+ +int virNetMessageEncodePayloadRaw(virNetMessagePtr msg, + const char *buf, + size_t len);

+ +void virNetMessageSaveError(virNetMessageErrorPtr rerr);