On 09/11/2015 09:26 AM, Jiri Denemark wrote:
Every single call to qemuDomainEventQueue() uses the following
pattern:
if (event)
qemuDomainEventQueue(driver, event);
Let's move the check for valid event to qemuDomainEventQueue and
simplify all callers.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
Notes:
Version 2:
- no change
src/qemu/qemu_blockjob.c | 6 ++--
src/qemu/qemu_cgroup.c | 3 +-
src/qemu/qemu_domain.c | 6 ++--
src/qemu/qemu_driver.c | 87 ++++++++++++++++-------------------------------
src/qemu/qemu_hotplug.c | 26 ++++++--------
src/qemu/qemu_migration.c | 24 +++++--------
src/qemu/qemu_process.c | 72 +++++++++++++--------------------------
7 files changed, 78 insertions(+), 146 deletions(-)
Yay! A couple still are behind "if (event) {" in qemu_driver
(qemuDomainCreateXML, qemuDomainRevertToSnapshot) as well as an if
(event_old) and if (event_new) in qemuDomainRename
ACK - I think those can be cleaned up
John