Re: [libvirt PATCH] qemu: snapshot: delete disk image only if parent snapshot is external

On Fri, Jan 10, 2025 at 15:21:21 +0100, Pavel Hrdina wrote: > When we are deleting external snapshot that is not active we only need > to delete overlay disk image of the parent snapshot. This works > correctly even if parent snapshot is external and active as it will have > another overlay created when user reverted to that snapshot. > > In case the parent snapshot is internal there are no overlay disk images > created as everything is stored internally within the disk image. In > this case we would delete the actual disk image storing internal > snapshots and most likely the original disk image as well resulting in > data loss once the VM is shutoff. > > Fixes: https://gitlab.com/libvirt/libvirt/-/issues/734 This definitely requires a NEWS entry as well.

> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/qemu/qemu_snapshot.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt;