Re: [PATCH 2/2 for 8.0] qemu: add index for isa-serial device using target.port

On Thu, 13 Jan 2022, Ani Sinha wrote: > > On Wed, 12 Jan 2022, Divya Garg wrote: > >> VM XML accepts target.port but this does not get passed while building the qemu >> command line for this VM. >> >> Signed-off-by: Divya Garg <divya.garg(a)nutanix.com&gt; >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c >> index d822533ccb..4130df0ed9 100644 >> --- a/src/qemu/qemu_command.c >> +++ b/src/qemu/qemu_command.c >> @@ -10718,6 +10718,8 @@ qemuBuildSerialChrDeviceProps(const virDomainDef *def, >> g_autoptr(virJSONValue) props = NULL; >> g_autofree char *chardev = g_strdup_printf("char%s", serial->info.alias); >> virQEMUCapsFlags caps; >> + const char *typestr; >> + int ret; > type should match the return type of this function. ret should be defined > as virJSONValue. I preferred your previous style to this one. > > Also please rebase this patch to the latest git HEAD and run "ninja test" > to make sure all tests passes. When I applied this patch to my tree, > qemuxml2argvtest failed. I think some more xmls needs fixing. oops! forgot to prune the huge set of xml changes not relavent to the context of my response from my last email. Apologies for that.