Re: [libvirt] [PATCH v4 1/3] Add per-guest S3/S4 state configuration

On 08/31/2012 07:59 AM, Martin Kletzander wrote: > There is a new <pm/> element implemented that can control what ACPI > sleeping states will be advertised by BIOS and allowed to be switched > to by libvirt. The default keeps defaults on hypervisor, otherwise > forces chosen setting. > The documentation of the pm element is added as well. > --- > +<pre> > + ... > + &lt;pm&gt; > + &lt;suspend-to-disk enabled='no'/&gt; > + &lt;suspend-to-ram enabled='yes'/&gt; 'no' and 'yes' here... > + &lt;/pm&gt; > + ...</pre> > + > + <dl> > + <dt><code>pm</code></dt> > + <dd>These elements enable ('on') or disable ('off') BIOS support 'on' and 'off' here... > <!-- > + Control ACPI sleep states (dis)allowed for the domain > + For each of the states the following rules apply: > + on: the state will be forcefully enabled > + off: the state will be forcefully disabled > + not specified: hypervisor will be left to decide its defaults > + <define name="suspendChoices"> > + <interleave> > + <optional> > + <attribute name="enabled"> > + <choice> > + <value>yes</value> > + <value>no</value> ...back to 'yes' and 'no' here. Fix the .html.in version to use the right naming. > + </choice> > + </attribute> > + </optional> > + </interleave> The <interleave> layer is not necessary here (you only have one sub-entry; furthermore, the sub-entry is an <attribute> which is already auto-interleaved; only <element> entries need interleaving). ACK with those tweaks.