Re: [libvirt] [PATCH libvirt-glib 1/5] Add suport for setting <filesystem> elements

> + > + if (!(old_node = gvir_config_xml_get_element(parent_node, child_name, NULL))) > + return; > + > + /* FIXME: should we make sure there are no multiple occurrences > + * of this node? > + */ > + xmlUnlinkNode(old_node); > + xmlFreeNode(old_node); > +} I think we will get memory corruption if this API is combined with _attach_child:

device_node = gvir_config_object_new("device"); fs_node = gvir_config_object_new("fs"); gvir_config_object_attach(device_node, fs_node); gvir_config_object_delete_child(device_node, "fs"); g_object_unref(G_OBJECT(fs_node)); The xmlNodePtr held by fs_node will be freed twice, once by _delete_child and when _finalize runs after the call to g_object_unref Having each GVirConfigObject keep a list of its GVirConfigObject children would make it possible to handle this case I think. I'm fine with getting this function in even if there are known issues with it.