Re: [libvirt] [PATCHv2] Ignore bridge template names with multiple printf conversions

On Tue, May 05, 2015 at 10:14:18AM -0600, Eric Blake wrote: > On 05/05/2015 10:05 AM, Ján Tomko wrote: >> For some reason, we allow a bridge name with %d in it, which we replace >> with an unsigned integer to form a bridge name that does not yet exist >> on the host. >>

>> + if (def->bridge && >> + (p = strchr(def->bridge, '%')) == strrchr(def->bridge, '%') && >> + strstr(def->bridge, "%d")) > > Simpler as: > > if (def->bridge && > strstr(def->bridge, "%d") == strrchr(def->bridge, '%')) I still don't see it. [A] strchr(def->bridge, '%') [B] strrchr(def->bridge, '%') [C] strstr(def->bridge, "%d")) When def->bridge is '%s%s%s%d', [A] points to the first %s, [B] points to the %d and so does [C] This string would pass the simplified condition (B == C), but not the full one (A != C)

Jan > > ACK with that simplification.