Re: [libvirt] [PATCH 5/5]virsh: mark '--shareable' as VSH_OFLAG_IGNORE
-----Original Message-----
From: Michal Privoznik [mailto:mprivozn@redhat.com]
> @@ -313,6 +313,7 @@ static const vshCmdOptDef opts_attach_disk[] = {
> },
> {.name = "shareable",
> .type = VSH_OT_BOOL,
> + .flags = VSH_OFLAG_IGNORE,
> .help = N_("shareable between domains")
> },
> {.name = "rawio",
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 7af5503..cb273e0 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1923,7 +1923,7 @@ expected.
> [[[I<--live>] [I<--config>] | [I<--current>]] |
[I<--persistent>]]
> [I<--driver driver>] [I<--subdriver subdriver>] [I<--cache
cache>]
> [I<--type type>] [I<--mode mode>] [I<--config>]
[I<--sourcetype
soucetype>]
> -[I<--serial serial>] [I<--wwn wwn>]
[I<--shareable>] [I<--rawio>]
> +[I<--serial serial>] [I<--wwn wwn>] [I<--rawio>]
> I<address> is the address of disk device in the form of
pci:domain.bus.slot.function,
> scsi:controller.bus.unit or ide:controller.bus.unit.
>
Wow, we've never wanted to hide any option before? I've recall
introducing VSH_OT_ALIAS, but there hasn't been anything else?
Do you mean we just treat --shareable as an alias for --mode like this:
{.name = "shareable",
- .type = VSH_OT_BOOL,
+ .type = VSH_OT_ALIAS,
- .help = N_("shareable between domains")
+ .help = "mode"
},
But with VSH_OT_ALIAS, auto complete could also get it.
We still need new flag to hide it.
Thanks!
Michal