Re: [libvirt] [PATCH 3/8] Add vcpu functions to libxl driver

Markus Groß wrote: > + maplen = (unsigned int) ceil((double) nvcpus / 8); > + if (VIR_ALLOC_N(bitmask, maplen) < 0) { > + virReportOOMError(); > + goto cleanup; > + } > + > + memset(bitmask, 0, maplen); > + for (i = 0; i < nvcpus; ++i) { > + pos = (unsigned int) floor((double) i / 8); > + bitmask[pos] |= 1 << (i % 8); > + } > + > + map.size = maplen; > + map.map = bitmask; > Hmm, could this be simplified to if (libxl_cpumap_alloc(&priv->ctx, &map)) { virReportOOMError() goto cleanup; } for (i = 0; i < nvcpus; i++) libxl_cpumap_set(&map, i);