Re: [libvirt] [PATCHv2] qemu: support live change of the bridge used by a guest network device

On 03/30/2012 12:22 PM, Laine Stump wrote: > Subject: [PATCH] qemu: add audit logs when switching bridges > > This adds in a standard audit log for detaching and attaching a > network device when the bridge being used is changed. > > All *attempts* to detach or attach a tap to a bridge are logged, along > with whether or not they are successful. > > The discussion about this led to the idea that the audit logs being > generated are insufficient, since they don't say anything about which > tap device is used, nor about which bridge it is attached to, but that > should be fixed by a separate patch, and this gets the current patch > properly wired into the infrastructure. > --- > src/qemu/qemu_hotplug.c | 36 ++++++++++++++++++++++++------------ > 1 files changed, 24 insertions(+), 12 deletions(-) ACK. This looks like you have correctly called into the audit framework, and I agree that a later patch to improve the audit framework to output additional useful information is now possible. I recommend that get this in before rc2.