Re: [libvirt] [libvirt-jenkins-ci PATCH 05/18] ansible: Add libvirt-cim project

On Mon, 2017-10-02 at 16:57 +0100, Daniel P. Berrange wrote: > > +packages: > > + - libcmpiutil-devel > > + - libconfig-devel > > + - libuuid-devel > > + - libxml2-devel > > + - libxslt > > + - wget > > + > > +extra_packages: > > + - libvirt-devel > > This isn't right - we should never install libvirt-devel on any of the > build hosts. Downstream projects are chained up to build against the > version of libvirt we just built. The same applies for other deps > we build that are used by other downstream pieces. That's why it's in 'extra_packages' rather than 'packages' ;) Again, this is only used during development. See group_vars/all/main.yml: # Wether to build software. While this is useful for figuring out # build dependencies, it should not be turned on in production # because it causes extra packages to be installed, which can # interfere with the CI jobs build: false and tasks/packages.yml: - name: '{{ project }}: Install extra packages' package: name: '{{ item }}' state: present with_items: '{{ extra_packages }}' when: - extra_packages is defined # Only extra additional packages if we're going to build - build Yuck, I accidentally that comment. You get the idea though. > Is there any way to get inheritance between these 'vars' files, so we don't > copy+paste the same content for every Fedora/CentOS version ? Mh, I have the feeling it might complicate things rather than make them nicer. I can look into it, though.