Re: [PATCHv2 4/5] tests: Add test case for nvme-ns device configuration
Hmm, does bootindex even work here? Shouldn't the bootindex apply to the
controller instead?
Both nvme and nvme-ns devices can have bootindex specified, and the corresponding
fw_cfg entries will be generated. I think it's more appropriate for us to specify the
boot order at the disk level in libvirt, just like the original design.
So since the controller type is 'nvme' the value of 'bus' ought to be
'nvme' as well instead of 'nvme-ns'. Same way as we have with
'scsi'.
I also thing that the prefix of dev should be just 'nvme'. Note that the
dev prefix is a libvirt identifier which may (and in this case will not)
be same as in the guest.
I'm fine with changing the bus naming to use nvme. As for the dev prefix,
let's discuss that in Martin Kletzander's thread.
Also since the controller supports multiple namespaces please add an
example which does so.
[1]
Indentation of the XML is incorrect here.
Also since multiple nvme controllers are possible please add an example
without serial. As noted above at least one of the examples ought to
have multiple namespaces to show the setup.
OK, I will add the corresponding
configuration.