Re: [libvirt PATCH 00/10] Unused cleanups

On Thu, Mar 13, 2025 at 04:52:13PM +0100, Martin Kletzander wrote: > On Thu, Mar 13, 2025 at 04:30:14PM +0100, Ján Tomko wrote: > > Patches 4-9/10 all depend on patch 3/10 > > 10/10 can be pushed independently > > > > Ján Tomko (10): > > qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker > > qemu: validate: fs: remove unneeded parameter > > qemu: remove qemuCaps from qemuBuildObjectCommandlineFromJSON > > qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine > > qemu: remove qemuCaps from qemuBuildTLSx509CommandLine > > qemu: remove qemuCaps from qemuBuildObjectCommandline > > qemu: remove qemuCaps from qemuBuildIOThreadCommandLine > > qemu: remove unused vm from qemuBuildSEVSNPCommandLine > > qemu: remove unused vm from qemuBuildPVCommandLine > > Remove unreachable breaks right after return > > > > I wonder whether there was some tool that got confused by return without > break in a switch statement, but in any case that's a problem of that > tool, if such thing exists. Probably a case where we did ret = .... and then did a simple search & replace for 's/ret = /return/', when we eliminated the need for a centralize return path thanks to g_auto*

With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|