Re: [libvirt] [REPOST PATCH v6 3/8] qemu: Remove private hostdev

On 11/23/2017 05:26 AM, Peter Krempa wrote: > On Wed, Nov 08, 2017 at 08:15:56 -0500, John Ferlan wrote: >> Since it's not longer used to shuttle the @secinfo, let's remove >> the private hostdev completely. >> >> Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; >> --- >> src/conf/domain_conf.c | 12 ++---------- >> src/conf/domain_conf.h | 4 +--- >> src/lxc/lxc_native.c | 2 +- >> src/qemu/qemu_domain.c | 44 ------------------------------------------- >> src/qemu/qemu_domain.h | 14 -------------- >> src/qemu/qemu_parse_command.c | 4 ++-- >> src/vbox/vbox_common.c | 2 +- >> src/xenconfig/xen_common.c | 2 +- >> src/xenconfig/xen_sxpr.c | 2 +- >> src/xenconfig/xen_xl.c | 2 +- >> tests/virhostdevtest.c | 2 +- >> 11 files changed, 11 insertions(+), 79 deletions(-) > > I guess we could have kept the allocation callback in XMLopt along with > the utiluty code around it for possible future use and just remove the > qemu-specific stuff, but I guess it does not matter much. > > ACK > I can adjust if you'd really prefer - it's not all that difficult to adjust. This patch then becomes just the qemu_domain.{c,h} adjustment.