Re: [libvirt] [PATCH] util: log error on OOM in virNetDevOpenvswitchAddPort
On 03/08/2012 02:00 PM, Eric Blake wrote:
On 03/08/2012 11:58 AM, Laine Stump wrote:
> OOM conditions silently returned failure.
> ---
> src/util/virnetdevopenvswitch.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
> index e2d5124..61bb9e1 100644
> --- a/src/util/virnetdevopenvswitch.c
> +++ b/src/util/virnetdevopenvswitch.c
> @@ -64,17 +64,17 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char
*ifname,
>
> if (virAsprintf(&attachedmac_ex_id,
"external-ids:attached-mac=\"%s\"",
> macaddrstr) < 0)
> - goto cleanup;
> + goto out_of_memory;
ACK.
Pushed. Thanks!