Re: [libvirt] [PATCH 3/5] setmem: implement the code to address the new API in the qemu driver

> + switch (flags) { > + case VIR_DOMAIN_MEM_CONFIG: > + persistentDef->mem.cur_balloon = newmem; > + ret = 0; > + break; > + > + case VIR_DOMAIN_MEM_LIVE: > + case VIR_DOMAIN_MEM_LIVE | VIR_DOMAIN_MEM_CONFIG: I think it is a little wierd to use a 'switch' statement for processing this. I'd just have a pair of 'if' statements eg if (flags & VIR_DOMAIN_MEM_LIVE) { .....do monitor stuff.... } if (flags & VIR_DOMAIN_MEM_CONFIG) { persistentDef->mem.cur_balloon = newmem; ret = virDomainSaveConfig(driver->configDir, persistentDef); }