Re: [libvirt] [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

> > Another reason for doing it in libvirt is that the serialization > > between cancellation and completion of migration ultimately is > > controlled by libvirt's lock. Doing this in QEMU makes it harder to > > reason about concurrency. I think you have to be careful when you talk about 'cancellation and completion of migration' - in that paragraph I don't think you mean the same thing as MIG_STATE_CANCELLED and MIG_STATE_COMPLETED, I think you're talking about the larger scale idea of completion after you take into account that the VM might be paused after qemu has gone to MIG_STATE_COMPLETED and libvirt might still decide it wants to give up and use the version on the source that's still paused.