Re: [libvirt] [PATCH 1/6 v3] libvirt: Add virDomainSetBlkioParameters virDomainGetBlkioParameters
On 02/21/2011 10:30 PM, Gui Jianfeng wrote:
Add virDomainSetBlkioParameters virDomainGetBlkioParameters
Signed-off-by: Gui Jianfeng <guijianfeng(a)cn.fujitsu.com>
+/**
+ * virDomainBlkioParameter:
+ *
+ * a virDomainBlkioParameter is the set of blkio parameteer
s/parameteer/parameters/
+++ b/python/libvirt-override.c
@@ -371,6 +371,23 @@ libvirt_virDomainSetSchedulerParameters(PyObject *self
ATTRIBUTE_UNUSED,
return VIR_PY_INT_SUCCESS;
}
+
+
+
+/* FIXME: This is a place holder for the implementation. */
+static PyObject *
+libvirt_virDomainSetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED,
+ PyObject *args ATTRIBUTE_UNUSED) {
+ return VIR_PY_INT_FAIL;
+}
+
+/* FIXME: This is a place holder for the implementation. */
+static PyObject *
+libvirt_virDomainGetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED,
+ PyObject *args ATTRIBUTE_UNUSED) {
+ return VIR_PY_INT_FAIL;
+}
+
This fails to compile with --enable-compile-warnings=error:
CC libvirtmod_la-libvirt-override.lo
cc1: warnings being treated as errors
libvirt-override.c:379:1: error: 'libvirt_virDomainSetBlkioParameters'
defined but not used [-Wunused-function]
libvirt-override.c:386:1: error: 'libvirt_virDomainGetBlkioParameters'
defined but not used [-Wunused-function]
You missed:
diff --git i/python/libvirt-override.c w/python/libvirt-override.c
index e09e2b5..4a9b432 100644
--- i/python/libvirt-override.c
+++ w/python/libvirt-override.c
@@ -4,7 +4,7 @@
* entry points where an automatically generated stub is
* unpractical
*
- * Copyright (C) 2005, 2007-2010 Red Hat, Inc.
+ * Copyright (C) 2005, 2007-2011 Red Hat, Inc.
*
* Daniel Veillard <veillard(a)redhat.com>
*/
@@ -3549,6 +3549,8 @@ static PyMethodDef libvirtMethods[] = {
{(char *) "virDomainGetSchedulerType",
libvirt_virDomainGetSchedulerType, METH_VARARGS, NULL},
{(char *) "virDomainGetSchedulerParameters",
libvirt_virDomainGetSchedulerParameters, METH_VARARGS, NULL},
{(char *) "virDomainSetSchedulerParameters",
libvirt_virDomainSetSchedulerParameters, METH_VARARGS, NULL},
+ {(char *) "virDomainSetBlkioParameters",
libvirt_virDomainSetBlkioParameters, METH_VARARGS, NULL},
+ {(char *) "virDomainGetBlkioParameters",
libvirt_virDomainGetBlkioParameters, METH_VARARGS, NULL},
{(char *) "virDomainSetMemoryParameters",
libvirt_virDomainSetMemoryParameters, METH_VARARGS, NULL},
{(char *) "virDomainGetMemoryParameters",
libvirt_virDomainGetMemoryParameters, METH_VARARGS, NULL},
{(char *) "virDomainGetVcpus", libvirt_virDomainGetVcpus,
METH_VARARGS, NULL},
ACK with those changes. I'll push this once I get through reviewing the
rest of the series.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)