[libvirt] [PATCH 6/1] build: avoid $(builddir) in Makefile

Older automake 1.9.6 (hello there, RHEL 5) did not populate $(builddir), which meant 'make check' failed with: make[3]: *** No rule to make target `/.libs/libvirt.la', needed by `check-symfile'. Stop. For that matter, even newer automake doesn't directly emit rules to build .libs/libvirt.la; we are better off basing our rules on the public ./libvirt.la. * src/Makefile.am (check-symfile): Delete useless variable. --- Pushing under the build-breaker rule. src/Makefile.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 39cbefd..2f15a37 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -310,8 +310,11 @@ PDWTAGS = \ echo 'WARNING: install the dwarves package to get pdwtags' >&2; \ fi -check-symfile: libvirt.syms $(builddir)/.libs/libvirt.la - $(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms $(builddir)/.libs/libvirt.so +# .libs/libvirt.so is built by libtool as a side-effect of the Makefile +# rule for libvirt.la +check-symfile: libvirt.syms libvirt.la + $(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms \ + .libs/libvirt.so PROTOCOL_STRUCTS = \ $(srcdir)/remote_protocol-structs \ -- 1.7.11.4