Re: [libvirt] [PATCH] maint: update to latest gnulib
On 12/06/2013 01:33 AM, Michal Privoznik wrote:
On 06.12.2013 00:52, Eric Blake wrote:
> A couple of fixes for bootstrap issues reported on IRC:
> - on some older glibc systems, ./configure could deadlock due to
> a glibc malloc bug
> - on FreeBSD systems, a broken autom4te coupled with gettext
> 0.18.3 prevents bootstrap; we can't work around it, but can at
> least inform the user why they have a problem
>
> And as always, portability fixes in other modules, some of which
> are used by libvirt.
>
> * .gnulib: Update to latest, in part for bootstrap improvements.
> * bootstrap: Resync to gnulib.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
>
> Hmm, in reading this gnulib changelog, I'm not sure I want to
> push right away: the line about md5 being tweaked to use openssl
> makes me wonder if this update is dragging in a new library
> dependency; I'll have to do a bit more investigation. But
> here's the patch, if anyone else also wants to investigate.
I think openssl is widely available. And yet, libvirt is already
dragging openssl in:
$ ldd ./daemon/.libs/libvirtd | grep ssl
libssl.so.1.0.0 => /usr/lib64/libssl.so.1.0.0 (0x00007f7ceed3e000)
That's pulled in indirectly; as is libcrypto.so, also from openssl.
This gnulib patch only adds an optional dependency on libcrypto, not
libssl; and upstream gnulib has since tweaked things to further default
to avoiding openssl. The official party line of Fedora is that openssl
is shipped as a system library, and therefore Fedora is okay if it uses
the configure option to pull in the library explicitly; but as openssl
is incompatible with GPL and is not present as a system library on all
platforms, the only safe default for upstream gnulib was to require
downstream users to explicitly request the use of the library.
As long as we don't change the spec file, we aren't changing behavior;
and while Fedora allows us to link to openssl, I'll leave such a spec
change for a later patch.
I'll go ahead and push a gnulib update on Jan 1 (which is when we have
to update anyways because of copyright year changes impacting 'make
syntax-check').
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)