Re: [PATCH 23/33] qemu: Enhance qemuDomainForbidLegacyUSBController()
On Wed, Jan 24, 2024 at 20:37:43 +0100, Andrea Bolognani wrote:
Currently, we have special handling for USB controllers of
s390x guests hardcoded into the command line generator. This is
not great from a layering point of view and, given the complex
interactions between the various parts, just makes things very
confusing.
In order to make things easier to reason about and centralize
decision making, increase the number of possible return values.
Honestly, to centralize decision making, the commandline code should not
at all call this function but simply rely on pre-filled list of
controllers. If the list is empty or contains a _NONE controller, don't
format anything. for _DEFAULT it should do '-usb'. Errors and anything
else should be decided before.
IMO this patch doesn't do anything for that.
For this series you should be able to separate the USB-unrelated changes
and get them merged.
If you want to have a look at doing this properly then go ahead,
otherwise I'll try having a look.