Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed
On Fri, 2021-03-26 at 11:15 +0100, Erik Skultety wrote:
On Wed, Mar 24, 2021 at 07:37:57PM +0100, Andrea Bolognani wrote:
> Currently, if GNU grep is not installed on a FreeBSD system the
> configuration step will fail with
>
> Program grep found: YES (/usr/bin/grep)
> Program /usr/local/bin/grep found: NO
>
> ERROR: Program '/usr/local/bin/grep' not found
Stupid question, but how does one need to invoke meson to actually hit ^this.
On my local FreeBSD 12:
$ ls -l /usr/local/bin/grep
ls: /usr/local/bin/grep: No such file or directory
$ pkg info | grep gnu
gnupg-2.2.26
gnutls-3.6.15
$ pwd
/home/test/libvirt
$ git describe
v7.1.0-328-g5f9330e724
$ meson --version
0.56.0
$ meson build -Dsystem=true | grep grep
Program grep found: YES (/usr/bin/grep)
This doesn't affect FreeBSD 12, but it can be hit without any
particular setup on -CURRENT, plus of course FreeBSD 13 once that's
released.
See
commit 7dd7ddac500cd3f453cd19606904ae406f5ffe03
Author: Roman Bogorodskiy <bogorodskiy(a)gmail.com>
Date: Tue Mar 2 18:31:36 2021 +0400
build-aux: require GNU grep on FreeBSD
FreeBSD 13.x and newer ship BSD grep which apparently has some
performance issues causing certain syntax check tests to run longer than
the default 30 seconds timeout used by meson.
However, GNU grep is still available through the textproc/gnugrep port,
so require it on FreeBSD if /usr/bin/grep is a BSD grep to make checks
pass in a reasonable time.
Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
for more information.
--
Andrea Bolognani / Red Hat / Virtualization