Re: [libvirt] [PATCH 2/2] syntax-check: mandate space after mid-line semicolon

On 25/05/13 01:19, Eric Blake wrote: > Enforce the style cleanup in the previous patch. > > * build-aux/bracket-spacing.pl: Enforce trailing spacing. > * cfg.mk (bracket-spacing-check): Tweak error wording. > * docs/hacking.html.in: Document the rule. > * HACKING: Regenerate. >

> + (echo "$(ME): incorrect whitespace, see HACKING for rules" > && exit 1) > I see you changed this when pushing: - (echo $(ME): incorrect whitespace around brackets, see HACKING for rules && exit 1) + { echo "$(ME): incorrect whitespace, see HACKING for rules" 2>&; \ + exit 1; } But it breaks build. I guess you indented to write "2>&1" there.