Re: [libvirt] [PATCH] qemu: add macvlan delete to qemuDomainAttachNetDevice cleanup

On 07/01/2013 06:42 PM, Laine Stump wrote: > On 07/01/2013 11:04 AM, Viktor Mihajlovski wrote: >> From: Matthew Rosato <mjrosato(a)linux.vnet.ibm.com&gt; > > This is a good catch, but incomplete. If you search for other > occurrences of virDomainConfNWFilterTeardown() and > qemuPhysIfaceConnect(), you will find the same problem exists in two > other places in the code: > > qemuBuildInterfaceCommandLine (during error cleanup, needs to be > called > for the one interface that was > partially > created) > qemuBuildCommandLine (during error cleanup, needs to be > called > for all interfaces that were > completely > created (up to last_good_net)) > > We really should fix them all in one patch, since they are all the same > problem. Thank you for your comments. I tested the two cases that you mentioned by forcing errors; in both, the macvtap will be released by code in qemuProcessStop(), which releases any macvtap in the domain's nets list. Is this sufficient, or did you still want something changed?

> > (Ideally, *all* guest interface setup for each interface should be > handled in a single function, and that function should be in the network > driver (networkReleaseActualDevice() seems properly situated). That way > it could be put behind an RPC, and the non-privileged libvirtd could > call it too (with proper credentials). That is a larger problem, though.) >