Re: [libvirt] [PATCH 1/1] Add vlantag parameter for openvswitch ports

On 08/08/2012 03:47 PM, Kyle Mestery wrote: Ha! We must have a telepathic link! I'm just about to add vlan support for SR-IOV VFs in PCI passthrough (aka "hostdev") and macvtap passthrough modes (the only thing that's kept me from action is indecision about where to put the vlan tag in the xml), and since at least one of those modes doesn't use <virtualport> at all, I was planning to add a <vlan tag='x'/> element at the toplevel of interface. There would also be a similar element at the toplevel of <network>, and another within <portgroup>. Something like this: <interface type='hostdev'> <mac address='52:54:00:11:22:33'/> <vlan tag='42'/> ... </interface> In this case, there is no <network> involved. Here's a case that uses a network: <interface type='network'> <mac address='52:54:00:11:22:33'/> <source network='net42'/> ... </interface> <network> <name>net42</name> <vlan tag='42'/> <forward mode='passthrough'> <interface dev='eth5'/> <interface dev='eth6'/> <interface dev='eth7'/> </forward> </network> In this second case, when the interface was brought up, it would allocate a physical device from the pool, and inherit the vlan tag, which would be set in the SR-IOV card's hardware as it's assigned to the guest. Note that hostdev passthrough would behave similarly (except forward mode would be 'hostdev') Finally, there may be a network with multiple vlans. portgroups could be used for that: <interface type='network'> <mac address='52:54:00:11:22:33'/> <source network='physnet' portgroup='production'/> ... </interface> <network> <name>net42</name> <forward mode='passthrough'> <interface dev='eth5'/> <interface dev='eth6'/> <interface dev='eth7'/> </forward> <portgroup name='production' default='yes'> <vlan tag='42'/> <bandwidth> .. </bandwidth> </portgroup> <portgroup name='test'> <vlan tag='666'/> <bandwidth> .. </bandwidth> </portgroup> </network> Selecting a different portgroup would put you on a difference vlan of the same switch. We would need to make a decision about which would take precedence if the vlan tag was given in multiple places - should the domain's request be honored, in order to allow it to made individual modifications to the general config in the <network>? Or should the network, as an entity of higher authority, be allowed to override what the domain asks for? I've never used vlan trunk groups, but I'm guessing whatever information you needed could be added as attributes to the <vlan> element. BTW, in general we don't like to have multiple pieces of data in a single element. We would prefer that they be in separate elements. So maybe if you wanted a single vlan tag, you could do it as above, but when you wanted a trunk group, you could do something like: <vlan trunk='yes'> <tag id='23'/> <tag id='24'/> <tag id='25'/> </vlan> (you might allow omitting the "trunk='yes'") Or possibly put them all at the top level: <vlan tag='23'/> <vlan tag='24'/> <vlan tag='25'/> and if you wanted a vlan trunk with only a single vlan in it: <vlan tag='23' trunk='yes'/> (actually, having multiple toplevel elements could get messy if we started talking about merging the elements from network/portgroup/interface together, so maybe that's not such a good idea). *Still another* possibility would be to put the vlan element as described above inside <virtualport>, then allow <virtualport> with no type to contain a <vlan> element. This would require a change to my recent <virtualport> merging patches, but they haven't been pushed yet. I'm not convinced I like that option, though. I think this needs a day or so to stew...