Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.1.0 on s390x

On Wed, 2020-11-18 at 17:18 +0100, Shalini Chellathurai Saroja wrote: > Signed-off-by: Shalini Chellathurai Saroja <shalini(a)linux.ibm.com> --- > The replies file is removed from this patch and is available in > https://gitlab.com/shalinichellathurai/libvirt/-/commit/1c34c07c434560d7f... > tests/domaincapsdata/qemu_5.1.0.s390x.xml | 230 + > .../caps_5.1.0.s390x.replies | 24617 ++++++++++++++++ > .../qemucapabilitiesdata/caps_5.1.0.s390x.xml | 3278 ++ > ...default-video-type-s390x.s390x-latest.args | 2 +- > .../disk-error-policy-s390x.s390x-latest.args | 12 +- > .../fs9p-ccw.s390x-latest.args | 4 +- > ...othreads-virtio-scsi-ccw.s390x-latest.args | 2 +- > ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 2 +- > .../s390x-ccw-graphics.s390x-latest.args | 4 +- > .../s390x-ccw-headless.s390x-latest.args | 4 +- > .../vhost-vsock-ccw-auto.s390x-latest.args | 4 +- > .../vhost-vsock-ccw.s390x-latest.args | 4 +- > 12 files changed, 28144 insertions(+), 19 deletions(-) > create mode 100644 tests/domaincapsdata/qemu_5.1.0.s390x.xml > create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.s390x.replies > create mode 100644 tests/qemucapabilitiesdata/caps_5.1.0.s390x.xml The patch looks good from a quick look; however, QEMU 5.2.0 was released a week ago and we have already merged capabilities for all architectures but s390x for that version so, unless there's something that is 5.1.0-specific that you need to test, can you please generate the capabilities for 5.2.0 instead? Thanks in advance!