Re: [libvirt PATCH 5/5] qemu: wire up support for maximum CPU model

Patch series looks fine to me, and we can certainly use this feature. One question I have about it: Does this apply to all architectures equally, or will we need to detect it from capabilities? I mean to say, if this was added to libvirt version X, then I might mandate that you have to use libvirt >= X and not bother detecting it (as the feature is so useful). But if it applies only on some architectures then we'd have to detect it anyway. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/