On Wed, May 11, 2011 at 14:13:30 -0600, Eric Blake wrote:
We were 31/73 on whether to translate; since less than 50% translated and since VIR_INFO is less than VIR_WARN which also doesn't translate, this makes sense.
* cfg.mk (sc_prohibit_gettext_markup): Add VIR_INFO, since it falls between WARN and DEBUG. * daemon/libvirtd.c (qemudDispatchSignalEvent, remoteCheckAccess) (qemudDispatchServer): Adjust offenders. * daemon/remote.c (remoteDispatchAuthPolkit): Likewise. * src/network/bridge_driver.c (networkReloadIptablesRules) (networkStartNetworkDaemon, networkShutdownNetworkDaemon) (networkCreate, networkDefine, networkUndefine): Likewise. * src/qemu/qemu_driver.c (qemudDomainDefine) (qemudDomainUndefine): Likewise. * src/storage/storage_driver.c (storagePoolCreate) (storagePoolDefine, storagePoolUndefine, storagePoolStart) (storagePoolDestroy, storagePoolDelete, storageVolumeCreateXML) (storageVolumeCreateXMLFrom, storageVolumeDelete): Likewise. * src/util/bridge.c (brProbeVnetHdr): Likewise. * po/POTFILES.in: Drop src/util/bridge.c. ---
I noticed this inconsistency while reviewing Lai's patch.
cfg.mk | 2 +- daemon/libvirtd.c | 10 +++++----- daemon/remote.c | 8 ++++---- po/POTFILES.in | 1 - src/network/bridge_driver.c | 12 ++++++------ src/qemu/qemu_driver.c | 6 +++--- src/storage/storage_driver.c | 18 +++++++++--------- src/util/bridge.c | 18 +++++++++--------- 8 files changed, 37 insertions(+), 38 deletions(-)
Fewer translated messages make for less frequent headaches for developers :-P Moreover this change really makes sense since the messages are not directly visible to users. ACK Jirka