On 02/28/13 00:17, Eric Blake wrote:
On 02/27/2013 04:51 AM, Ján Tomko wrote:
> Only release ports that have been allocated before.
>
> This fixes these issues:
> * trying to release ports when qemuProcessStart fails before port
> allocation
> * trying to release the SPICE TLS port if spice_tls is 0
> * failing to release SPICE port with autoport=off (when only one
> of them is -1)
> ---
> v1:
https://www.redhat.com/archives/libvir-list/2013-February/msg01464.html
> Use a pair of booleans in domain private data instead of a new field
> in the domain definition.
Closer, but where is this information saved across libvirtd restarts?
Hint: qemu_domain.c:qemuDomainObjPrivateXML{Format,Parse}()
We don't preserve the port allocator state across restarts, so saving
this would do nothing in the best case. (the worse cases being printing
an error or (possibly?) marking a used port as unused).
Jan