Re: [libvirt] [PATCH option 1] Use fallocate directly if possible
According to Daniel Veillard on 3/2/2010 9:53 AM:
>> +#if defined(HAVE_POSIX_FALLOCATE) &&
!defined(HAVE_FALLOCATE)
>
> Redundant parenthesis. I know upstream gnulib's maint.mk warns about
> them; did we turn them off in libvirt's 'make syntax-check'?
Hum, what's redundant here ?
It's perfectly acceptable (and less typing) to do:
#if defined HAVE_POSIX_FALLOCATE && !defined HAVE_FALLOCATE
Whether it is also more legible is a matter of opinion.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 320 bytes)