On Mon, Jun 08, 2009 at 04:31:35PM -0500, Doug Goldstein wrote:
The following patch stubs out virDomainRename() as an available API
function. I'm just making sure I'm doing this right. I know there were
some plans to include documentation about adding API to the website
but I don't see it. The included patch does not include my example
driver for qemu and test.
Just looking for a thumbs up/down whether I should continue or not and
whether I'm adding it right.
The mechanics looks fine to me,
+int virDomainRename (virDomainPtr
domain,
+ const char *name);
However I would prefer an extra unsigned int flags, which may be
unused at first but can help on the long term. For example some
hypervisors may allow rename only under some conditions (for example the
domain being shut down) and the flags could carry those extra semantics.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/