Re: [PATCH] Increase timeout for tests and syntax-check
On Fri, 2021-01-29 at 14:53 +0000, Daniel P. Berrangé wrote:
On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
> On Fri, 2021-01-29 at 12:48 +0000, Daniel P. Berrangé wrote:
> > I'm not convinced we want to optimize for the slowest hardware
> > we can find, especially when there's an easy option of setting
> > --timeout-multiplier=10.
>
> It's not complicated to add the option, but the fact that Debian,
> SUSE and now Fedora all need to specify a timeout multiplier hints to
> the fact that perhaps the default timeout is just too small.
AFAIK, Fedora hasn't set any timeout multiplier in our builds.
With
commit 70307548d1622bfeffd60c86e62098d165c95074
Author: Cole Robinson <crobinso(a)redhat.com>
Date: Thu Jan 21 16:54:45 2021 -0500
spec: Increase meson test timeout 10x
Tests time out when building in slow environments, like emulated
s390x in Fedora copr. Bump up the test timeout
Reviewed-by: Neal Gompa <ngompa13(a)gmail.com>
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
the timeout multiplier has been added to the upstream spec file,
which the Fedora spec file is based on, so while you're correct that
Fedora is not yet using it, it's fair to assume it will soon make its
way there for the benefit of e.g. the virt-preview COPR.
--
Andrea Bolognani / Red Hat / Virtualization