Re: [libvirt] [PATCH] qemu: make attaching disk partition to VM illegal
On Mon, Sep 30, 2019 at 08:38:20AM +0200, Peter Krempa wrote:
On Fri, Sep 27, 2019 at 12:41:29 -0300, Daniel Henrique Barboza
wrote:
>
>
> > + virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> > + _("can't attach disk partition '%s',
please attach whole disk instead"),
> > + disk->dst);
>
> Break line to keep the line <= 80 chars plz.
Note that 80 columns is no longer a strict requirement especially if it
would make code harder to read. In this case it can be broken.
I had the line broken originally but fixed it later as per
https://libvirt.org/hacking.html#errors
which looked authoritative (and also seemed to make sense).
I'll gladly fix the patch however I'm not clear at the moment as to which
guidelines actually apply.
Thanks,
pvl