Re: [libvirt] [PATCH glib] Remove dead cleanup code in object fetch_list helpers

On 08/15/2013 08:41 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > The fetch_list helper cleanup code iterates over the > elements in 'lst' array free'ing each one. This is dead > code, however, since the only way to get there is from > codepaths which do not populate 'lst' elements. > > This fixes two coverity DEADCODE reports > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > libvirt-gobject/libvirt-gobject-connection.c | 6 +----- > libvirt-gobject/libvirt-gobject-storage-pool.c | 6 +----- > 2 files changed, 2 insertions(+), 10 deletions(-) > This does fix the coverity error, but for both the "gint i;" is now unnecessary resulting in: libvirt-gobject-storage-pool.c:324:10: error: unused variable 'i' [-Werror=unused-variable] gint i;