Re: [libvirt] [PATCHv2] leaseshelper: split out virLeaseNew

On 02/05/2016 11:49 AM, Ján Tomko wrote: > +static int > +virLeaseNew(virJSONValuePtr *lease_ret, > + const char *mac, > + const char *clientid, > + const char *ip, > + const char *hostname, > + const char *iaid, > + const char *server_duid) Coverity complains - order of arguments appears swapped... ...iaid, server_duid) [1]

> @@ -405,6 +461,9 @@ main(int argc, char **argv) > switch ((enum virLeaseActionFlags) action) { > case VIR_LEASE_ACTION_ADD: > case VIR_LEASE_ACTION_OLD: > + /* Create new lease */ > + if (virLeaseNew(&lease_new, mac, clientid, ip, hostname, server_duid, iaid) < 0) While here it's ...server_duid, iaid)

John