Re: [libvirt] [PATCH 04/17] docs: add footer to all pages
On Fri, Nov 04, 2016 at 02:19:22PM +0100, Ján Tomko wrote:
On Mon, Oct 31, 2016 at 12:41:45PM +0000, Daniel P. Berrange wrote:
> Add a footer to all pages containing a blurb about the
> code of conduct, and links to social media sites.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> docs/libvirt.css | 44 ++++++++++++++++++++++++++++++++++++++++++++
> docs/page.xsl | 12 ++++++++++++
> 2 files changed, 56 insertions(+)
>
> diff --git a/docs/page.xsl b/docs/page.xsl
> index e3b8d5b..8f6a8c7 100644
> --- a/docs/page.xsl
> +++ b/docs/page.xsl
> @@ -170,6 +170,18 @@
> </form>
> </div>
> </div>
> + <div id="footer">
> + <div id="social">
> + <ul>
> + <li><a
href="https://twitter.com/hashtag/libvirt">twitter</a>...
This is essentially an ad for twitter. Unless they are sponsoring the
project, it feels out of place here.
Errr, it is linking to libvirt related content people share on twitter.
> + <li><a
href="https://plus.google.com/communities/109522598353007505282"...
plus</a></li>
I presume that community is run by either you or some other libvirt maintainer,
which is what I would expect from such link.
> + <li><a
href="http://stackoverflow.com/questions/tagged/libvirt">sta...
This feels like <a
href="https://www.google.com/?q=libvirt">google</a>;.
Stack overflow is much more targetted than a global websearch - it is
a user self-help forum, and the libvirt tag is directly relevant.
Linking to related content on other community related sites is a very
relevant thing - libvirt does not exist in an island where everything
happens on websites run by ourselves. Encouraging engagement with libvirt
via these external social media sites is a key way to promote libvirt and
ensure our community grows over time.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|