Re: [libvirt] [PATCH] fix MinGW compilation(200808)

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > On Tue, Aug 05, 2008 at 01:52:58PM +0200, Jim Meyering wrote: >> Atsushi SAKAI <sakaia(a)jp.fujitsu.com&gt; wrote: >> ... >> > network_conf.c:290: warning: implicit declaration of function `inet_aton' >> > network_conf.c:290: warning: nested extern declaration of `inet_aton' >> >> We can/should use inet_pton instead. Then, not only do we use what seems >> to be the preferred interface, but there is a gnulib module by the same >> name that can come into play if it too is missing. > > Even better would be to use getaddrinfo() with AI_NUMERIC, since we > already require getaddrinfo() to work on Windows for the remote driver Dan, If you don't object, I'll go for the simpler interface (and smaller change). However I've just noticed that that will require an adjustment of the gnulib license for the inet_pton module. But that shouldn't be a problem, since the code in question is glibc-derived.