Re: [libvirt] [PATCH] use gnulib via a submodule

Daniel P. Berrange wrote: ... >> Subject: [PATCH] use automake-1.11's silent-rules option, when possible >> >> Don't use mylibtool, (subsumed by automake's silent rules) >> Its use was causing a non-srcdir build to fail. >> * Makefile.am (EXTRA_DIST): Remove mylibtool. >> * configure.in: Don't use mylibtool. >> >> * configure.in: Use AM_SILENT_RULES([yes]), >> but only if that m4 macro is defined. >> Thus, it works even on systems that lack automake-1.11. >> Daniel Berrange suggested adding the conditional, so that >> we don't have a hard requirement on 1.11, e.g., for RHEL5. ... > ACK, I've tested on RHEL-5, the only issue was a minor warning from > aclocal, which was evidently harmless. > > aclocal:configure.in:12: warning: macro `AM_SILENT_RULES' not found in library Thanks. pushed