Re: [libvirt] [PATCH v3] qemu: Allow domain reboot after core dump

On Fri, Sep 23, 2011 at 10:23:15AM -0600, Eric Blake wrote: [...] > Independent of your patch, I also just realized that > virDomainSave[Flags], virDomainRestore[Flags], > virDomainSaveImageGetXMLDesc, virDomainSaveImageDefineXML, and > virDomainCoreDump all have the same design issue: they are not very > nice for remote management. Each of these functions convert a > relative path name into absolute name on the client side, before > passing the string to the remote side, even though the actual file > to be used is on the remote side. This is not always guaranteed to > work, and also leaves things stuck with the file being on the remote > side (no way to dump the core across the network back to the client, > like there is with virDomainScreenshot). yes, known annoying issue with those entry point nearly since day 1 of libvirt. > At some point, we may want to introduce new API that performs these > types of operations on a stream, where the client can then manage > the stream. And/or we may want to introduce a way to specify the > "file" to manipulate as a virStorageVolPtr, or even a string > relative to a virStoragePoolPtr, for more precise control of where > the file ends up without having to first "absolutize" the file > argument in the client. Right we now have enough support to provide better APIs with streams, the 'only' problem is that basically the operation should only succeed if the whole stream was fetched correctly, because the last thing we want is a virDomainSaveStream suceeeding but where the data were not completely and reliably transmitted to the user, the data loss would be too huge, we can't stop the domain in such a failure. That's a bit tricky ... The alternate way which would have my preference is virDomainManagedSave... entry points where libvirt has the authority on the storage and can make sure everything is available, and then a specific function to stream back a managed save through a stream. Then we also have the existing entry point to delete a managed save so we have only 1 remote streaming function to really implement and get right,