Re: [libvirt] [PATCH v2 4/4] qemu: command: Use -name guest= if available

On 05/04/2016 10:56 AM, Cole Robinson wrote: > -name guest= is the explicit parameter for passing a VM name. Using > it is required to allow a VM with an '=' in the name > > https://bugzilla.redhat.com/show_bug.cgi?id=1276485 > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 4 ++++ > tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + > tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + > tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + > tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + > tests/qemuxml2argvdata/qemuxml2argv-name-escape.args | 8 ++++---- > tests/qemuxml2argvdata/qemuxml2argv-name-escape.xml | 2 +- > tests/qemuxml2argvtest.c | 2 +- > 10 files changed, 17 insertions(+), 6 deletions(-) > You're overloading the name-escape test with the "guest=" option which I'm never quite sure how others feel about. I would think you'd want a separate test that just adds the "guest=".

I also see this biting us at some point in the future in some test when 'guest=' becomes the default and all the test outputs have to change to add that.