Re: [libvirt] [PATCH] Only build virDomainObjFormat if not building proxy.
On Thu, Feb 25, 2010 at 04:09:43PM -0700, Eric Blake wrote:
According to Chris Lalancette on 2/25/2010 12:48 PM:
> While building under RHEL-5, I got a compile warning because
> virDomainObjFormat was defined but not used. That came about
> because in RHEL-5 we build with "#define PROXY", and
> virDomainObjFormat is only used with !PROXY. Move the
> define.
ACK.
>
> Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
Is there a project policy on Signed-off-by lines? According to the git
No, it's just an habit of some of us :-), not a formal requirement,
[...]
copyright). Right now, 'git log' makes it look like
libvirt's S-o-b usage
is ad hoc, according to the contributor's habits.
yes,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/